]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
StTextureCache: plug leak in not-found icon case
authorColin Walters <walters@verbum.org>
Thu, 5 May 2011 20:28:05 +0000 (16:28 -0400)
committerColin Walters <walters@verbum.org>
Wed, 11 May 2011 20:18:10 +0000 (16:18 -0400)
Need to free the key too.

https://bugzilla.gnome.org/show_bug.cgi?id=649508

src/st/st-texture-cache.c

index 182851bad74fbfd69659492791676ff9711fdd72..fba794aafa25aa09c3cd512235aa8d12f4405bdb 100644 (file)
@@ -1223,10 +1223,11 @@ load_gicon_with_colors (StTextureCache    *cache,
   else
     {
       /* Blah; we failed to find the icon, but we've added our texture to the outstanding
-       * requests.  In that case, just undo what create_texture_lookup_status did.
+       * requests.  In that case, just undo what create_texture_and_ensure_request() did.
        */
        g_slist_foreach (request->textures, (GFunc) g_object_unref, NULL);
        g_slist_free (request->textures);
+       g_free (request->key);
        g_free (request);
        g_hash_table_remove (cache->priv->outstanding_requests, key);
        g_object_unref (texture);